[UXD][AAP-25027] AWX - updates to Teams section breadcrumbs & headers #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AWX
tiyiprh
force-pushed
the
AWX-team-breadcrumb&header
branch
from
854519e to
b08c49c
Compare
tiyiprh
force-pushed
the
AWX-team-breadcrumb&header
branch
2 times, most recently
from
e5a98fa to
9da2317
Compare
tiyiprh
force-pushed
the
AWX-team-breadcrumb&header
branch
from
9da2317 to
203d03e
Compare
daphnemaeve
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Looks great! Two last tests seem to be failing when attempting to verify the page title when editing a team, as it is expecting the old title of "Edit Team". Editing the two instances of cy.verifyPageTitle('Edit Team'); in cypress/e2e/awx/access/teams/teams.cy.ts to match the new page title should resolve that!
|
daphnemaeve
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-25027
Updates to Teams section breadcrumbs & headers section breadcrumbs & headers