Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXD][AAP-25027] AWX - updates to Users section breadcrumbs & headers #2733

Merged
merged 3 commits into from
Aug 21, 2024
Merged

[UXD][AAP-25027] AWX - updates to Users section breadcrumbs & headers #2733

merged 3 commits into from
Aug 21, 2024

Conversation

tiyiprh
Copy link
Contributor

@tiyiprh tiyiprh commented Jul 16, 2024

https://issues.redhat.com/browse/AAP-25027

Updates to Users section breadcrumbs & headers section breadcrumbs & headers

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Jul 16, 2024
@tiyiprh tiyiprh force-pushed the AWX-users-breadcrumb&header branch from 13a1225 to d7396d2 Compare July 17, 2024 22:04
@github-actions github-actions bot added the AFW Ansible Framework label Jul 18, 2024
@tiyiprh tiyiprh force-pushed the AWX-users-breadcrumb&header branch from 685db3c to 7da9984 Compare August 19, 2024 16:55
@github-actions github-actions bot removed the AFW Ansible Framework label Aug 19, 2024
@tiyiprh tiyiprh force-pushed the AWX-users-breadcrumb&header branch from 7da9984 to 4a0a438 Compare August 20, 2024 16:19
@tiyiprh tiyiprh requested a review from daphnemaeve August 20, 2024 16:20
@github-actions github-actions bot removed the E2E End-to-end testing label Aug 21, 2024
daphnemaeve
daphnemaeve reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@daphnemaeve daphnemaeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two last tests are failing in cypress/e2e/awx/access/users/users.cy.ts because it is expecting the old page title. Editing the two places where we verify the page title cy.verifyPageTitle('Edit User'); in that file should resolve this!

@tiyiprh tiyiprh force-pushed the AWX-users-breadcrumb&header branch from 6807465 to 378da60 Compare August 21, 2024 17:12
@github-actions github-actions bot added the E2E End-to-end testing label Aug 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tiyiprh tiyiprh merged commit 5708ce3 into main Aug 21, 2024
42 checks passed
@tiyiprh tiyiprh deleted the AWX-users-breadcrumb&header branch August 21, 2024 20:06
ZitaNemeckova pushed a commit that referenced this pull request Aug 22, 2024
@tiyiprh @ZitaNemeckova
[UXD][AAP-25027] AWX - updates to Users section breadcrumbs & headers (…
ec94298 
…#2733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphnemaeve daphnemaeve daphnemaeve approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiyiprh @daphnemaeve