Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXD][AAP-25027] AWX - updates to Credentials & Cred Types section breadcrumbs & headers #2735

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[UXD][AAP-25027] AWX - updates to Credentials & Cred Types section breadcrumbs & headers #2735

merged 2 commits into from
Aug 22, 2024

Conversation

tiyiprh
Copy link
Contributor

@tiyiprh tiyiprh commented Jul 16, 2024

https://issues.redhat.com/browse/AAP-25027
Updates to Credentials & Cred Types section breadcrumbs & headers

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing CCT Component tests labels Jul 16, 2024
@tiyiprh tiyiprh closed this Jul 18, 2024
@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from a00189d to 14efd9e Compare July 18, 2024 12:58
@tiyiprh tiyiprh reopened this Jul 18, 2024
acruzgon
acruzgon requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@acruzgon acruzgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Go to /cypress/support/awx-commands.ts
  2. In line 288 replace with cy.verifyPageTitle('Create credential type');

cypress/e2e/awx/administration/credentialTypes.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/awx/administration/credentialTypes.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/awx/administration/credentialTypes.cy.ts Outdated Show resolved Hide resolved
@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from 0866583 to 3e8037e Compare July 18, 2024 18:18
@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from 3e8037e to 41586d9 Compare August 19, 2024 15:37
@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from 41586d9 to 15a07fe Compare August 20, 2024 14:52
@tiyiprh tiyiprh requested a review from daphnemaeve August 20, 2024 15:00
@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from 15a07fe to 94ec206 Compare August 21, 2024 19:14
@tiyiprh
Copy link
Contributor Author

tiyiprh commented Aug 22, 2024

@daphnemaeve There were 4 failing previously yesterday and then I did a rebase and now there are still 2 failing.

@tiyiprh tiyiprh force-pushed the AWX-credtypes&creds-breadcrumb&header branch from 94ec206 to 616891a Compare August 22, 2024 17:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

acruzgon
acruzgon approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@acruzgon acruzgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nixocio nixocio merged commit 3289645 into main Aug 22, 2024
40 checks passed
@nixocio nixocio deleted the AWX-credtypes&creds-breadcrumb&header branch August 22, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acruzgon acruzgon acruzgon approved these changes

@nixocio nixocio nixocio approved these changes

@jamestalton jamestalton Awaiting requested review from jamestalton jamestalton is a code owner

@akus062381 akus062381 Awaiting requested review from akus062381 akus062381 is a code owner

@vishsanghishetty vishsanghishetty Awaiting requested review from vishsanghishetty

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey AlexSCorey is a code owner

@vidyanambiar vidyanambiar Awaiting requested review from vidyanambiar vidyanambiar is a code owner

@keithjgrant keithjgrant Awaiting requested review from keithjgrant keithjgrant is a code owner

@lgalis lgalis Awaiting requested review from lgalis lgalis is a code owner

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova ZitaNemeckova is a code owner

@marshmalien marshmalien Awaiting requested review from marshmalien marshmalien is a code owner

@kialam kialam Awaiting requested review from kialam kialam is a code owner

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil MilanPospisil is a code owner

@himdel himdel Awaiting requested review from himdel himdel is a code owner

@daphnemaeve daphnemaeve Awaiting requested review from daphnemaeve

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiyiprh @nixocio @acruzgon