Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Dialog Fixes #3034

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Select Dialog Fixes #3034

merged 2 commits into from
Aug 21, 2024

Conversation

jamestalton
Copy link
Contributor

@jamestalton jamestalton commented Aug 21, 2024 •
edited
Loading

There is a timing issue with browse dialogs that use dynamic filters.
It should not impact customers, but it does impact fast tests.
Long term we should look for a fix, but for now, replacing test selection of items to not use the browse dialogs.

@jamestalton
Select Dialog Fixes
c7239cd 
Signed-off-by: James Talton <[email protected]>
@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Aug 21, 2024
AlexSCorey
AlexSCorey requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the commented code

kialam
kialam previously approved these changes Aug 21, 2024
View reviewed changes
@jamestalton
cleanup commeted out code
caff814 
Signed-off-by: James Talton <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jamestalton jamestalton merged commit d6bbf20 into main Aug 21, 2024
40 of 42 checks passed
@jamestalton jamestalton deleted the Select-Dialog-Fixes branch August 21, 2024 21:33
ZitaNemeckova pushed a commit that referenced this pull request Aug 22, 2024
@jamestalton @ZitaNemeckova
Select Dialog Fixes (#3034)
f96da67 
Signed-off-by: James Talton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSCorey AlexSCorey AlexSCorey requested changes

@kialam kialam kialam left review comments

@nixocio nixocio Awaiting requested review from nixocio nixocio is a code owner

@akus062381 akus062381 Awaiting requested review from akus062381 akus062381 is a code owner

@vishsanghishetty vishsanghishetty Awaiting requested review from vishsanghishetty

@vidyanambiar vidyanambiar Awaiting requested review from vidyanambiar vidyanambiar is a code owner

@keithjgrant keithjgrant Awaiting requested review from keithjgrant keithjgrant is a code owner

@lgalis lgalis Awaiting requested review from lgalis lgalis is a code owner

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova ZitaNemeckova is a code owner

@marshmalien marshmalien Awaiting requested review from marshmalien marshmalien is a code owner

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil MilanPospisil is a code owner

@himdel himdel Awaiting requested review from himdel himdel is a code owner

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamestalton @kialam @AlexSCorey