Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAP-28420][AAP-AAP-29675][AAP-29676] Add user and teams access tabs to the Event Streams page #3048

Merged
merged 5 commits into from
Aug 26, 2024
Merged

[AAP-28420][AAP-AAP-29675][AAP-29676] Add user and teams access tabs to the Event Streams page #3048

merged 5 commits into from
Aug 26, 2024

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Aug 22, 2024 •
edited
Loading

Add user and teams access tabs to the Event Streams page

Screenshot from 2024-08-26 16-48-51
Screenshot from 2024-08-26 16-48-45
Screenshot from 2024-08-26 16-48-40
Screenshot from 2024-08-26 16-40-00

Screenshot from 2024-08-26 14-27-48
Screenshot from 2024-08-26 14-19-21

Screenshot from 2024-08-22 16-58-51
Screenshot from 2024-08-22 16-55-57

Screenshot from 2024-08-22 13-35-39

@github-actions github-actions bot added EDA Label to indicate changes relevant to EDA CCT Component tests labels Aug 22, 2024
@lgalis lgalis marked this pull request as draft August 22, 2024 21:12
@lgalis lgalis closed this Aug 23, 2024
@lgalis lgalis reopened this Aug 23, 2024
@lgalis lgalis changed the title [AAP-28420] Add user and teams access tabs to the Event Streams page [AAP-28420][AAP-AAP-29675][AAP-29676] Add user and teams access tabs to the Event Streams page Aug 23, 2024
@lgalis lgalis force-pushed the AAP-28420_event_stream_rbac branch 3 times, most recently from 42f792d to e91d3ab Compare August 26, 2024 18:45
@lgalis lgalis marked this pull request as ready for review August 26, 2024 18:51
@lgalis lgalis force-pushed the AAP-28420_event_stream_rbac branch from 3c63607 to d962831 Compare August 26, 2024 20:12
@lgalis
Update empty pages and add permission checks for the create button
5c7683a 
Add rbac checks for the Event stream actions and the edit page
@lgalis lgalis force-pushed the AAP-28420_event_stream_rbac branch from d962831 to 5c7683a Compare August 26, 2024 20:23
keithjgrant
keithjgrant previously approved these changes Aug 26, 2024
View reviewed changes
keithjgrant
keithjgrant previously approved these changes Aug 26, 2024
View reviewed changes
vidyanambiar
vidyanambiar previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

I noticed a missing resource name specifically for Event Streams. It appears that the role_user_assignments response does not contain summary_fields.content_object:

image

@lgalis lgalis dismissed stale reviews from vidyanambiar and keithjgrant via 01e4bfc August 26, 2024 22:11
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lgalis lgalis merged commit fc23c32 into main Aug 26, 2024
39 of 40 checks passed
@lgalis lgalis deleted the AAP-28420_event_stream_rbac branch August 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithjgrant keithjgrant keithjgrant approved these changes

@vidyanambiar vidyanambiar vidyanambiar left review comments

Assignees
No one assigned
Labels
CCT Component tests EDA Label to indicate changes relevant to EDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgalis @keithjgrant @vidyanambiar