Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor notifiers org tests and fix custom command failure #3061

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Refactor notifiers org tests and fix custom command failure #3061

merged 3 commits into from
Aug 27, 2024

Conversation

akus062381
Copy link
Member

No description provided.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Aug 27, 2024
@akus062381 akus062381 force-pushed the refactor-organization-notifications-tests branch from 64ac487 to e246c55 Compare August 27, 2024 15:44
@vidyanambiar
Copy link
Member

vidyanambiar commented Aug 27, 2024 •
edited
Loading

I'm getting a failure on can edit a Notification on its details page and assert the edited info:
Looks like email is lowercase in the UI.
image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

himdel
himdel approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the hub test failure is a known problem, being fixed separately)

@akus062381 akus062381 merged commit 1eae3c6 into main Aug 27, 2024
39 of 40 checks passed
@akus062381 akus062381 deleted the refactor-organization-notifications-tests branch August 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@nixocio nixocio Awaiting requested review from nixocio nixocio is a code owner

@jamestalton jamestalton Awaiting requested review from jamestalton jamestalton is a code owner

@vishsanghishetty vishsanghishetty Awaiting requested review from vishsanghishetty

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey AlexSCorey is a code owner

@keithjgrant keithjgrant Awaiting requested review from keithjgrant keithjgrant is a code owner

@lgalis lgalis Awaiting requested review from lgalis lgalis is a code owner

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova ZitaNemeckova is a code owner

@marshmalien marshmalien Awaiting requested review from marshmalien marshmalien is a code owner

@kialam kialam Awaiting requested review from kialam kialam is a code owner

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil MilanPospisil is a code owner

@vidyanambiar vidyanambiar Awaiting requested review from vidyanambiar vidyanambiar is a code owner

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akus062381 @vidyanambiar @himdel