Consolidate image and server setup in multiple checks #14422
Conversation
|
My belief is that checks too a little longer on this because changes to the Makefile triggered the image rebuilding. I don't recall exactly why this happens but I believe I've seen it before. |
| outputs: | ||
| ip: | ||
| description: The IP of the tools_awx_1 container | ||
| value: ${{ steps.data.outputs.ip }} | ||
| admin-token: | ||
| description: OAuth token for admin user | ||
| value: ${{ steps.data.outputs.admin_token }} |
There was a problem hiding this comment.
These steps don't exist here, nix?
.github/workflows/ci.yml
Outdated
| - name: Build awx_devel image for running checks | ||
| uses: ./.github/actions/awx_ci_setup | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Would it make sense to have run_awx_devel include awx_ci_setup?
While we do want to run awx_ci_setup independently sometimes, I don't think we'd ever want to run run_awx_devel without depending on awx_ci_setup.
AlanCoding
force-pushed
the
one_setup
branch
from
85c81e0 to
5c9628d
Compare
| @@ -26,7 +26,6 @@ jobs: | |||
| with: | |||
| build-ui: true | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| log-filename: e2e-${{ matrix.job }}.log | |||
There was a problem hiding this comment.
@relrod This log-filename is an input to the other action (upload_awx_devel_logs), not this action. It seems to have not failed anything, but this seemed to be a bug.
I could, however, see the argument for having run_awx_devel call upload_awx_devel_logs in the same way that I'm now having it call the image build action. In that case, it would be an input, and we also would be more compact by never calling upload_awx_devel_logs
But that would require adding it as something like a "finalizer" step, which needs research.
There was a problem hiding this comment.
looks like it's not a thing actions/runner#1478
There was a problem hiding this comment.
Yeah that is what I really wanted to do originally, but there's no way when using a composite action. :(
AlanCoding
added
qe:e2e
SUMMARY
Some time ago, it was me who introduced
make github_ci_setupand the runner one too. I figure that it is easiest if I am the one to delete it, since we have now seen an independent solution evolve for the same problem, via shared github actions.ISSUE TYPE
COMPONENT NAME