Pull the correct collection plugin for the product #15658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamack
force-pushed
the
inv-plugin-split
branch
from
126d887 to
4bf0ba8
Compare
webknjaz
reviewed
Nov 27, 2024
webknjaz
reviewed
Nov 27, 2024
webknjaz
reviewed
Nov 27, 2024
github-actions
bot
added
the
dependencies
djyasin
approved these changes
Dec 10, 2024
the related PR has been merged
github-actions
bot
removed
the
dependencies
|
The schema change failure here is a good thing. Prior to this PR we were in a state where we surfaced both the supported and unsupported version of the inventory plugins. |
chrismeyersfsu
approved these changes
Dec 11, 2024
AlanCoding
reviewed
Dec 11, 2024
| @@ -1248,3 +1249,7 @@ def _new_func(*args, **kwargs): | |||
|
|
|||
| def unified_job_class_to_event_table_name(job_class): | |||
| return f'main_{job_class().event_class.__name__.lower()}' | |||
|
|
|||
|
|
|||
| def load_all_entry_points_for(entry_point_subsections: list[str], /) -> dict[str, EntryPoint]: | |||
There was a problem hiding this comment.
Can you explain what the / is doing here? Maybe it's a new python thing I'm unaware of, but maybe it's unintended.
There was a problem hiding this comment.
my understanding is that it's using this syntax https://docs.python.org/3.8/whatsnew/3.8.html#positional-only-parameters. it was suggested by @webknjaz here #15658 (comment). I think it's to enforce standard behavior.
AlanCoding
approved these changes
Dec 12, 2024
|
@jessicamack let's get this merged 👍 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There exist several cases of inventory plugins with the same name but different implementations. Historically, AWX/Controller pivoted on attributes on the inventory source to figure out which ansible inventory to call. Now, instead of a single implementation we've split them into two implementations completely. This PR is to implement the change to pick which one we want and when.
Requires: ansible/awx-plugins#61
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION