Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference inject_credentials at its new home #15693

Conversation

chrismeyersfsu
Copy link
Member

SUMMARY

Reference inject_credentials at its new home

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

@github-actions github-actions bot added dependencies Pull requests that update a dependency file component:api labels Dec 6, 2024
@AlanCoding
Copy link
Member

So what needs to be merged before this is functional?

@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch 3 times, most recently from dd30f19 to 2507468 Compare December 12, 2024 00:44
@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch from 2507468 to a65bf4d Compare December 17, 2024 15:40
@chrismeyersfsu chrismeyersfsu marked this pull request as ready for review December 18, 2024 13:24
@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch from a65bf4d to b6b34c1 Compare December 18, 2024 13:24
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch 2 times, most recently from 175b44a to c3a7275 Compare December 18, 2024 14:03
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 18, 2024
@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch 2 times, most recently from fdab4ae to 7b8afac Compare December 18, 2024 14:25
@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch from 7b8afac to ef6284b Compare December 18, 2024 21:33
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 18, 2024
@@ -688,7 +556,7 @@ def __init__(self, namespace, **kwargs):
for k in ('inputs', 'injectors'):
if k not in kwargs:
kwargs[k] = {}
kwargs.setdefault('custom_injectors', None)
# kwargs.setdefault('custom_injectors', None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# kwargs.setdefault('custom_injectors', None)

@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch from ef6284b to d8af315 Compare December 19, 2024 13:56
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 19, 2024
* Consume inject_credential from its new home, awx_plugins.interfaces
@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credentials-out-of-awx branch from d8af315 to b6a1675 Compare December 19, 2024 13:58
@chrismeyersfsu chrismeyersfsu merged commit bd96000 into ansible:devel Dec 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants