-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference inject_credentials at its new home #15693
Merged
chrismeyersfsu
merged 2 commits into
ansible:devel
from
chrismeyersfsu:AAP-35749-move-inject-credentials-out-of-awx
Dec 19, 2024
Merged
Reference inject_credentials at its new home #15693
chrismeyersfsu
merged 2 commits into
ansible:devel
from
chrismeyersfsu:AAP-35749-move-inject-credentials-out-of-awx
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Pull requests that update a dependency file
component:api
labels
Dec 6, 2024
So what needs to be merged before this is functional? |
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
3 times, most recently
from
December 12, 2024 00:44
dd30f19
to
2507468
Compare
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
from
December 17, 2024 15:40
2507468
to
a65bf4d
Compare
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
from
December 18, 2024 13:24
a65bf4d
to
b6b34c1
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
2 times, most recently
from
December 18, 2024 14:03
175b44a
to
c3a7275
Compare
github-actions
bot
removed
the
dependencies
Pull requests that update a dependency file
label
Dec 18, 2024
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
2 times, most recently
from
December 18, 2024 14:25
fdab4ae
to
7b8afac
Compare
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
from
December 18, 2024 21:33
7b8afac
to
ef6284b
Compare
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Dec 18, 2024
AlanCoding
reviewed
Dec 18, 2024
awx/main/models/credential.py
Outdated
@@ -688,7 +556,7 @@ def __init__(self, namespace, **kwargs): | |||
for k in ('inputs', 'injectors'): | |||
if k not in kwargs: | |||
kwargs[k] = {} | |||
kwargs.setdefault('custom_injectors', None) | |||
# kwargs.setdefault('custom_injectors', None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# kwargs.setdefault('custom_injectors', None) |
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
from
December 19, 2024 13:56
ef6284b
to
d8af315
Compare
github-actions
bot
removed
the
dependencies
Pull requests that update a dependency file
label
Dec 19, 2024
* Consume inject_credential from its new home, awx_plugins.interfaces
chrismeyersfsu
force-pushed
the
AAP-35749-move-inject-credentials-out-of-awx
branch
from
December 19, 2024 13:58
d8af315
to
b6a1675
Compare
Quality Gate passedIssues Measures |
AlanCoding
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Reference inject_credentials at its new home
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION