Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test warnings that escaped somehow #15714

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix test warnings that escaped somehow #15714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awx/main/tests/functional/models/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@
assert workflow_job.scm_branch is None
assert workflow_job.job_tags is None
assert workflow_job.skip_tags is None
assert len(workflow_job.labels.all()) is 0
assert len(workflow_job.labels.all()) == 0

Check warning on line 380 in awx/main/tests/functional/models/test_workflow.py

View check run for this annotation

Codecov / codecov/patch

awx/main/tests/functional/models/test_workflow.py#L380 

Added line #L380 was not covered by tests

# fields from prompts used
workflow_job = workflow_job_template.create_unified_job(**prompts_data)
Expand Down
4 changes: 2 additions & 2 deletions awx/main/tests/unit/utils/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@

def test_good_call(self, regex_expr, re_flags):
h = HostnameRegexValidator(regex=regex_expr, flags=re_flags)
assert (h("192.168.56.101"), None)
assert h("192.168.56.101") is None

Check warning on line 321 in awx/main/tests/unit/utils/test_common.py

View check run for this annotation

Codecov / codecov/patch

awx/main/tests/unit/utils/test_common.py#L321 

Added line #L321 was not covered by tests

def test_bad_call(self, regex_expr, re_flags):
h = HostnameRegexValidator(regex=regex_expr, flags=re_flags)
Expand All @@ -336,4 +336,4 @@

def test_bad_call_with_inverse(self, regex_expr, re_flags, inverse_match=True):
h = HostnameRegexValidator(regex=regex_expr, flags=re_flags, inverse_match=inverse_match)
assert (h("@#$%)$#(TUFAS_DG"), None)
assert h("@#$%)$#(TUFAS_DG") is None

Check warning on line 339 in awx/main/tests/unit/utils/test_common.py

View check run for this annotation

Codecov / codecov/patch

awx/main/tests/unit/utils/test_common.py#L339 

Added line #L339 was not covered by tests
Loading