-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API documentation rendering (#15116) #15726
Conversation
@tvo318 I know there has been some talk around docs and I am not sure what changes (if any) you all had in mind, take a peak whenever you get back. |
This appears well thought-out. I started the checks, we want to make sure that the schema check is functioning as normal. Otherwise, I think this is doing a lot of important updates. Super minor, |
Thank you for taking your time to view the PR. I'll take care of the lint and tests failures right away. |
Quality Gate passedIssues Measures |
|
^ that's actually fantastic. This is a check which is intended by fail by design, it just lets us know what changed. So that needs to be reviewed to assure intentionality. As you say, looks good.
For what you mention:
And these tags never had any thought go into them before. More specific entries are better.
This actually introduces a lot of new tags, and that's what most of the text volume of the diff shows
And that seems to cover all types of changes shown there. I was worried about how hard it would be to make this work correctly, but it seems you've already got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and seems like a really solid improvement. Thanks very much @spaut33 🚀
SUMMARY
This is a fix for #15116
The change addresses the need for better organization and usability in the Swagger/Redoc UI by automatically grouping endpoints into sections by
swagger_topic
attribute if present, otherwise it uses model's name or fallback toapi
if nothing above setted in the view. It also respectsdeprecated
attribute.Introduced
CustomSwaggerAutoSchema
to handle tagging for views which is globally applied using default settings.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
API documentation is available in the dev-mode: http://localhost:8013/api/swagger/ and http://localhost:8013/api/redoc/
If merged, the documentation will appear as follows: