add message type in the response as per suggestion

ansible · Jan 8, 2024 · ee459b0 · ee459b0
1 parent 515ca53
commit ee459b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/aap_eda/wsapi/consumers.py b/src/aap_eda/wsapi/consumers.py
@@ -90,11 +90,13 @@ async def receive(self, text_data=None, bytes_data=None):
         data = json.loads(text_data)
         logger.debug(f"AnsibleRulebookConsumer received: {data}")
 
+        msg_type = data.get("type")
         try:
             msg_type = MessageType(data.get("type"))
         except ValueError:
             logger.error(f"Unsupported message type: {data}")
-            await self.send('{"error": "unsupported message type"}')
+            payload = {"error": f"unsupported message type: {msg_type}"}
+            await self.send(text_data=json.dumps(payload))
             await self.close()
             return
 

diff --git a/tests/integration/wsapi/test_consumer.py b/tests/integration/wsapi/test_consumer.py
@@ -78,7 +78,7 @@ async def test_valid_websocket_route_wrong_type():
     await communicator.send_to(text_data='{"type": "unsuported_type"}')
     response = await communicator.receive_from()
     assert (
-        response == '{"error": "unsupported message type"}'
+        response == '{"error": "unsupported message type: unsuported_type"}'
     ), "Unexpected error message"
     await communicator.disconnect()