-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-39136] - Register DAB Feature Flags endpoint #1196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
+ Coverage 93.39% 93.41% +0.01%
==========================================
Files 263 264 +1
Lines 15086 15118 +32
==========================================
+ Hits 14090 14122 +32
Misses 996 996
Flags with carried forward coverage won't be shown. Click here to find out more.
|
54ba607
to
a579210
Compare
@zkayyali812 the coverage report said there are two missings. Could you improve it? |
Hey @hsong-rh , I was thinking that this may be sufficient for now, and ideally cover them them in our test-suite, once ATF is updated to consume this API. however if you know how I can cover these better, I would love to learn. |
@hsong-rh / @Alex-Izquierdo I think I addressed the code coverage here. Not sure if I can retrigger the codecov automation to update its comment above. |
Quality Gate passedIssues Measures |
API is accessible at -
/api/eda/v1/feature_flags_state/
.To test, deploy EDA and ensure API is accessible at above endpoint. One can modify the FLAGS variable to see the state reflected at the API endpoint at installtime.
Also satisfies - https://issues.redhat.com/browse/AAP-39595