feat: add edited_at field to activation #1199
Conversation
Expose this field in API for activations. Also write the field to rulebook process log if the activation has been edited. implements AAP-38382
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## feature/edit-activation #1199 +/- ##
==========================================================
Coverage ? 93.47%
==========================================================
Files ? 263
Lines ? 15179
Branches ? 0
==========================================================
Hits ? 14189
Misses ? 990
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| "%Y-%m-%dT%H:%M:%S.%fZ" | ||
| ) | ||
| log_handler.write( | ||
| f"The activation was edited at {edited_at}", flush=True |
There was a problem hiding this comment.
@bzwei Can you paste a screen shot of the Activation log in this PR?
There was a problem hiding this comment.
@bzwei To be consistent can be use the created_at if the edited_at is missing that way the log will remain the same.
There was a problem hiding this comment.
@mkanoor The edited_at timestamp is not the message logging time. It is part of the log message, just like other timestamps appear in the output. Screenshot is posted.
I purposely not log the edited time if not present. When it is missing, it is an indication that the activation is original, never updated. Or perhaps I can write a message here "The activation has never been edited"
There was a problem hiding this comment.
@bzwei Thats ok leave it the way it is for now. Did you forget to the add the screen shot?
There was a problem hiding this comment.
@mkanoor I posted screen shot but it did not get displayed somehow. Now it is visible
|
|
||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("core", "0056_alter_activation_options"), |
There was a problem hiding this comment.
where is this 0056 migration file? do you miss it?
There was a problem hiding this comment.
0056 migration exists in feature/edit-activation branch
Expose this field in API for activations. Also write the field to rulebook process log if the activation has been edited.
implements AAP-38382