test: add more tests to analytics settings and scheduling #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAP-39884 Test and improve code coverage for analytics collection feature
|
| headers={"X-ANSIBLE-SERVICE-AUTH": token}, | ||
| verify=settings.RESOURCE_SERVER["VALIDATE_HTTPS"], | ||
| ) | ||
| except Exception as e: |
There was a problem hiding this comment.
Is there a reason to catch a generic exception?
There was a problem hiding this comment.
Ideally I should catch any error from requests.exception.*, there are too many types in this module.
There was a problem hiding this comment.
to catch any exception from requests I think you can just catch RequestException which is parent of the rest.
https://github.com/psf/requests/blob/main/src/requests/exceptions.py#L12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAP-39884 Test and improve code coverage for analytics collection feature