-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [AAP-37813] Replace EDA filters with DAB rest filters #1234
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
- Coverage 93.81% 93.71% -0.11%
==========================================
Files 284 273 -11
Lines 15913 15785 -128
==========================================
- Hits 14929 14793 -136
- Misses 984 992 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
93196fd
to
0a36f65
Compare
e2e test run with updated api client: https://github.com/ansible/eda-server/actions/runs/13793345570 |
d491e97
to
f24c84a
Compare
@lgalis this might be a breaking change for the UI depending on how it is using the current EDA filters. Could you help us confirm? |
@Dostonbek1 should we put it as draft until have confirmation it will not break the UI, just to prevent accidental merges? |
f24c84a
to
1f1c5d0
Compare
|
@Dostonbek1 this looks good but we need to ensure that it works with @lgalis's UI components. Plus she would have to make changes to take advantage of the new filters which can be combined which wasn't allowed earlier. Would it be possible to build a quay.io image for UI testing |
This PR replaces our existing filters with rest-filters app that DAB provides, which is more capable and helps us align across platform.
AAP-37813
✅ e2e tests are passing with updated tests and api client