fix: avoid race condition in max running processes #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Feb 13, 2024
bzwei
reviewed
Feb 13, 2024
bzwei
previously approved these changes
Feb 14, 2024
mkanoor
previously approved these changes
Feb 15, 2024
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Alex-Izquierdo
force-pushed
the
fix-max-activation-race
branch
from
841c5fd to
88735c9
Compare
Signed-off-by: Alex <[email protected]>
bzwei
approved these changes
Feb 20, 2024
hsong-rh
approved these changes
Feb 21, 2024
Alex-Izquierdo
added a commit
to Alex-Izquierdo/eda-server
that referenced
this pull request
Feb 21, 2024
Signed-off-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having set the max_running_activations to 1 in the environment, I create several activations. As expected, as I create the activations, the first one starts running an the rest remain in pending state. However, if after that I delete the one that is running, then the rest of the pending rulebook activations all start running at the same time (ignoring the max_running_activations parameter)
Jira: https://issues.redhat.com/browse/AAP-20719