Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty_requirements to collection_remote #419

Closed
wants to merge 1 commit into from

Conversation

saito-hideki
Copy link
Member

What does this PR do?

Add new empty_requirements parameter to the collection_remote module clear requirements.yml contents.

How should this be tested?

  tasks:
  - galaxy.galaxy.collection_remote:
      ah_host: "galaxy.example.com"
      ah_username: "<YOUR_ADMIN_USERNAME>"
      ah_password: "<YOUR_PASSWORD>"
      name: "example-remote"
      empty_requirements: true
      sync_dependencies: true
      validate_certs: false
      state: present

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

  • None

@djdanielsson
Copy link
Contributor

I am not sure if I like this, I think we might just need to tweak the code (role and/or python) to accept "" and thus remove any requirements that are currently in the remote. Thoughts @sean-m-sullivan @Tompage1994

Copy link
Contributor

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut feeling is that this isn't a good way to do this. Ideally we should just be able to set requirements: [] and it work. I'm intreaged as to why this doesn't work and how it does actually work through the API

@Tompage1994
Copy link
Contributor

My gut feeling is that this isn't a good way to do this. Ideally we should just be able to set requirements: [] and it work. I'm intreaged as to why this doesn't work and how it does actually work through the API

I've found a better way to do this where this bug is simply fixed. I'm going to close this PR, but thanks for the contribution @saito-hideki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remove requirements.yml from a remote.
3 participants