-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin codecov action to v4.5.0 and update dependabot.yml to ignore v4.6.0 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonlhart
requested review from
audgirka and
sshedmake
and removed request for
a team
October 3, 2024 16:18
alisonlhart
requested review from
ssbarnea,
cidrblock and
shatakshiiii
and removed request for
audgirka and
sshedmake
October 3, 2024 16:19
shatakshiiii
approved these changes
Oct 4, 2024
ssbarnea
previously requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also modify dependabot config to prevent it from picking v4.6.0 when running on action otherwise, you change will be undone by it.
I think that we can assume that next version will address the issue, just skip 4.6.0
alisonlhart
force-pushed
the
fix/pin-codecov-version
branch
from
October 4, 2024 15:53
bfad0a4
to
60a64b3
Compare
@ssbarnea Added! |
alisonlhart
changed the title
Pin codecov version to 4.5.0
Pin codecov action to v4.5.0 and update dependabot.yml to ignore v4.6.0
Oct 4, 2024
alisonlhart
force-pushed
the
fix/pin-codecov-version
branch
from
October 4, 2024 16:19
d9c4680
to
2e5b975
Compare
alisonlhart
force-pushed
the
fix/pin-codecov-version
branch
from
October 4, 2024 19:06
2e5b975
to
f0a6ba1
Compare
alisonlhart
force-pushed
the
fix/pin-codecov-version
branch
from
October 4, 2024 19:20
f0a6ba1
to
5f83352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the codecov version in our tox workflow from v4 to v4.5.0, since v4.6.0 introduced a regression causing this error:
Error:
Codecov: Failed to get OIDC token with url: https://codecov.io./ Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
Updates
dependabot.yml
to skip version v4.6.0.Adds
dependabot.yml
to the.ansible-lint
exclude_paths list, since it's failing on the quotes surrounding thedependency_name
andversions
values.Codecov issue: codecov/codecov-action#1594