Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace force param to overwrite in extension webview #1663

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tanwigeetika1618
Copy link
Contributor

JIRA : https://issues.redhat.com/browse/AAP-36015

Replace force Parameter with overwrite in Webview Extension

This PR updates the webview in the vscode-ansible extension to replace the deprecated force parameter with the overwrite parameter. The changes include:

  • Modifying the checkbox label and description in the webview UI.
  • Updating the associated logic to reflect the use of the overwrite parameter.

These changes align with the latest parameter updates for the Ansible collection initialization process.

@alisonlhart
Copy link
Contributor

Approved!
We can ignore the failed codecov-patch test because the lines changed were also not covered in the past, and adding a test that would cover those lines is greatly outside the scope of this PR.

The overall project coverage increases by 1.62% with this PR, because of a new test for the createAnsibleCollectionPage file, which was previously untested.

Great work @tanwigeetika1618 !! 🎊

@alisonlhart
Copy link
Contributor

Moving back to draft - there's an issue with versions of creator using --overwrite before 24.10.0.

Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see above comment)

@alisonlhart alisonlhart marked this pull request as draft November 21, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants