Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Extension diff via antipad #5751

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

hui-zhou-a
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (4fc3435) to head (81c6fef).
Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5751      +/-   ##
==========================================
- Coverage   84.75%   75.00%   -9.76%     
==========================================
  Files         157      158       +1     
  Lines       61631    61713      +82     
==========================================
- Hits        52237    46286    -5951     
- Misses       9394    15427    +6033     

@hui-zhou-a hui-zhou-a marked this pull request as draft February 10, 2025 09:23
ring630 and others added 4 commits February 10, 2025 10:33
… extension-diff-via-antipad

# Conflicts:
#	tests/system/solvers/test_45_workflows.py
@hui-zhou-a hui-zhou-a marked this pull request as ready for review February 10, 2025 10:13
@Samuelopez-ansys
Copy link
Member

Hi @hui-zhou-a , good job, but could you please add the corresponding documentation? Thanks!

@hui-zhou-a
Copy link
Contributor Author

Hi @hui-zhou-a , good job, but could you please add the corresponding documentation? Thanks!

@Samuelopez-ansys I will add documentation. It is failing test on Linux. Any advice?

@SMoraisAnsys
Copy link
Collaborator

Hi @hui-zhou-a , good job, but could you please add the corresponding documentation? Thanks!

@Samuelopez-ansys I will add documentation. It is failing test on Linux. Any advice?

It might have been related to the migration to AEDT 25.1 and the conflict we identified with SolutionSolvers. I'm merging main into your PR after the VMs reboot. Hopefully, this should fix the CICD issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants