Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Update export page to give error for properties not in common for lumped and distributed export pages #5815

Conversation

ramin4667
Copy link
Contributor

Description

This PR adds error messages for properties not applicable to the defined design.

Issue linked

NA

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

…age_to_give_error_for_properties_not_in_common_for_lumped_and_distributed_export_pages_
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Feb 21, 2025
@ramin4667 ramin4667 requested a review from myoung301 February 21, 2025 14:52
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (7cc111c) to head (0bc3779).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5815      +/-   ##
==========================================
- Coverage   84.86%   84.85%   -0.01%     
==========================================
  Files         158      158              
  Lines       61903    61903              
==========================================
- Hits        52531    52525       -6     
- Misses       9372     9378       +6     

@ramin4667
Copy link
Contributor Author

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@myoung301 myoung301 merged commit ecfdc79 into main Feb 21, 2025
43 checks passed
@myoung301 myoung301 deleted the FEAT__Update_export_page_to_give_error_for_properties_not_in_common_for_lumped_and_distributed_export_pages branch February 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants