Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify port in get coupling in range #5817

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

amichel0205
Copy link
Contributor

Description

Identify port location of S parameters in coupling range

Issue linked

Improve get_coupling_in_range() function such to identify port location #5796

Checklist

  • [yes] I have tested my changes locally.
  • [yes] I have added necessary documentation or updated existing documentation.
  • [yes I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • [ yes] I have reviewed my changes before submitting this pull request.
  • [yes] I have linked the issue or issues that are solved by the PR if any.
  • [yes] I have agreed with the Contributor License Agreement (CLA).

@amichel0205 amichel0205 added the enhancement New features or code improvements label Feb 22, 2025
@amichel0205 amichel0205 self-assigned this Feb 22, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 2.04082% with 48 lines in your changes missing coverage. Please review.

Project coverage is 17.93%. Comparing base (ecfdc79) to head (cde3790).
Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (2.04%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5817       +/-   ##
===========================================
- Coverage   84.85%   17.93%   -66.93%     
===========================================
  Files         158      158               
  Lines       61903    61936       +33     
===========================================
- Hits        52530    11107    -41423     
- Misses       9373    50829    +41456     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve get_coupling_in_range() function such to identify port location
1 participant