Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding test for start_timeout arg #3554

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 18, 2024

Description

As the title.

Issue linked

Close #3408

Checklist

@germa89 germa89 requested a review from a team as a code owner November 18, 2024 12:45
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 18, 2024 12:45
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
Copy link
Collaborator Author

germa89 commented Nov 18, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) November 18, 2024 12:45
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Nov 18, 2024
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (7f64156) to head (a1c8f56).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
- Coverage   91.32%   90.52%   -0.80%     
==========================================
  Files         187      187              
  Lines       14640    15665    +1025     
==========================================
+ Hits        13370    14181     +811     
- Misses       1270     1484     +214     

@germa89 germa89 merged commit abcb5ae into main Nov 18, 2024
60 of 62 checks passed
@germa89 germa89 deleted the test/adding-test-for-start_timeout-arg branch November 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start_timeout doesn't get pass when start_instance=False
2 participants