-
Notifications
You must be signed in to change notification settings - Fork 132
chore: active support for Python 3.13 #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 88.30% 88.28% -0.03%
==========================================
Files 187 187
Lines 14819 14819
==========================================
- Hits 13086 13083 -3
- Misses 1733 1736 +3 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when @RobPasMue suggestions have beem implemented.
Only VTK 9.4.0 is compatible with 3.13 |
Thanks @RobPasMue. I updated all the vtk versions, including the ones within |
Seems to me like you are hitting some PyVista 3.13 incompatibilities. |
Yep. This is on hold until ansys/ansys-tools-visualization-interface#208 is fixed. |
We are going to need a patch release in ATVI ( |
We need it! xDDD |
By the way, getting Python segfaults when using VTK 9.4.0... so this PR has to wait... |
Summarise:
So we must wait for pyvista 0.44.3. |
PyVista |
Description
Active support for Python 3.13
Closes #3600
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)