Skip to content

build: update to vtk 9.4.1 #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ env:
DPF_PORT: 21004
MAPDL_PACKAGE: ghcr.io/ansys/mapdl
ON_CI: True
PYTEST_ARGUMENTS: '-vvv -rxXsa --color=yes --durations=30 --random-order --random-order-bucket=class --maxfail=10 --reruns 3 --reruns-delay 4 --cov=ansys.mapdl.core --cov-report=html --timeout=180 --profile-svg --profile'
PYTEST_ARGUMENTS: '-vvv -rxXsal --full-trace --tb=long --color=yes --durations=30 --random-order --random-order-bucket=class --maxfail=10 --reruns 3 --reruns-delay 4 --cov=ansys.mapdl.core --cov-report=html --timeout=180 --profile-svg --profile'

BUILD_CHEATSHEET: True
PYMAPDL_DEBUG_TESTING: True
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/3615.dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
build: update to vtk 9.4.1
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ tests = [
"pytest-timeout==2.3.1",
"pytest==8.3.4",
"scipy==1.15.2",
"vtk==9.3.1",
"vtk==9.4.1",
]
doc = [
"ansys-dpf-core==0.10.1",
Expand Down Expand Up @@ -103,7 +103,7 @@ doc = [
"sphinx==8.2.1",
"sphinxcontrib-websupport==2.0.0",
"sphinxemoji==0.3.1",
"vtk==9.3.1",
"vtk==9.4.1",
]

[tool.flit.module]
Expand Down
17 changes: 10 additions & 7 deletions src/ansys/mapdl/core/plotting/visualizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,15 +225,10 @@ def get_meshes_from_plotter(self):
list[pv.PolyData]
Plotted meshes.
"""
datasets = []
for actor in self.scene.actors.values():
if hasattr(actor, "mapper"):
datasets.append(actor.mapper.dataset)

return [
actor.mapper.dataset
for actor in self.scene.actors.values()
if hasattr(actor, "mapper")
if hasattr(actor, "mapper") and hasattr(actor.mapper, "dataset")
]

def add_labels(
Expand Down Expand Up @@ -856,4 +851,12 @@ def scene(self):
@property
def meshes(self):
"""Return the meshes."""
return self.scene.meshes
try:
# Pyvista 0.44.2 makes this method to fail, so adding a backup plan
return self.scene.meshes
except AttributeError:
return [
actor.mapper.dataset
for actor in self.scene.actors.values()
if hasattr(actor, "mapper") and hasattr(actor.mapper, "dataset")
]
Loading