Add DB migration to Docker entrypoint. #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of this PR: #1
My adjustments
db/migrations/2018_10_01_000000_create_users_tables.php
-> Kept failing for me, not sure why or how. Made it slightly more resilient with some checks to see if the table already exists. If there is a way to use Illuminate instead to do an "IF NOT EXISTS" check, that would be better. I just don't know Illuminate.docker/entrypoint.sh
-> added some log messages!startup.sh
-> Removed the extra migrate now that it runs in entrypoint. At least, in theory. I don't really know Docker either and have never run startup.sh