feat: Connect conversations to GitHub issues (#12) #47
Conversation
| conversationSummary?: string | string[] | null; | ||
| } | ||
|
|
||
| // Define the GitHub issue type |
There was a problem hiding this comment.
I think most of the comments in this PR are unnecessary, the code reads well on its own
| updatedAt: string; | ||
| } | ||
|
|
||
| export const GitHubIssueButton = ({ |
There was a problem hiding this comment.
Please integrate this into the command bar instead, we're trying to avoid adding buttons. Ideally the form should work similarly to "add note" / tool execution
There was a problem hiding this comment.
I updated the button to now be in 'command bar' instead of in conversation tabs.
checkout this commit : 7a2b578
screenshot :
| const [selectedIssueNumber, setSelectedIssueNumber] = useState<number | null>(null); | ||
|
|
||
| // Get conversation details to check if a GitHub issue is already linked | ||
| const { data: conversation, refetch: refetchConversation } = api.mailbox.conversations.get.useQuery( |
There was a problem hiding this comment.
Would be a bit nicer to use useConversationContext
| <> | ||
| <span className="inline-flex items-center rounded-full bg-muted px-1.5 py-0.5 text-xs font-medium text-muted-foreground mr-1"> | ||
| Closed | ||
| </span> | ||
| <HumanizedTime time={conversation.closedAt ?? conversation.updatedAt} titlePrefix="Closed on" /> | ||
| </> |
There was a problem hiding this comment.
This doesn't look related?
| try { | ||
| setIsLoading(true); | ||
| setRepositories( | ||
| await utils.client.mailbox.github.repositories.query({ |
There was a problem hiding this comment.
useQuery should simplify the state handling here (or let me know if there's a reason you're not using it!)
|
|
||
| return { | ||
| accessToken: data.access_token, | ||
| username: userResponse.data.login, |
There was a problem hiding this comment.
Why do we save the username?
There was a problem hiding this comment.
@vikaswakde _a Thanks for the PR, the functionality looks great! I've added some initial comments (in 2 reviews because I mis-clicked ...), could you take a look?
Apologies some of these weren't clear, we haven't had a chance to document things in detail yet
| console.error("Error listing repository issues:", error); | ||
| throw new Error("Failed to list issues for this repository"); |
There was a problem hiding this comment.
In general I think we can let things like this fail rather than having custom error handlers (if it's for the message, we should throw a tRPC error class in the procedure)
| import { createGitHubIssue, getGitHubIssue, listRepositoryIssues, updateGitHubIssueState } from "@/lib/github/client"; | ||
| import { mailboxProcedure } from "./procedure"; | ||
|
|
||
| export const githubConversationsRouter = { |
There was a problem hiding this comment.
How about we nest this under conversations and use conversationProcedure
|
|
||
| if (mailbox?.githubAccessToken) { | ||
| // Map conversation status to GitHub issue state | ||
| const githubState = updatedConversation.status === "closed" ? "closed" : "open"; |
There was a problem hiding this comment.
I don't think we should do this, "closed" for the conversation just means we've replied, not that the issue is fixed
Implements GitHub integration for Helper, allowing users to:
helperai-github-integration-demo.mov
helper-ai-github-issues-creation-demo.mp4
This integration enables teams to track support requests and bugs directly
from Helper conversations, with bidirectional synchronization ensuring
that issue status is always up-to-date in both systems.
Closes #12