[antlr4] Do not leave EOF in an undefined state after including antlr-runtime.h #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuxuan Chen <[email protected]>
yuxuanchen1997
force-pushed
the
users/yuxuanchen1997/fix-antlr-common-eof-undef
branch
from
f8e1ad7 to
a172cd8
Compare
yuxuanchen1997
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuxuan Chen [email protected]
antlr-common.hattempts to undefine EOF and leaves it in an undefined state. However, this breaks when you attempt to include header that expects EOF to be there. (e.g. you can't include any more after includingantlr-runtime.h)This patch proposes using
push_macroto save the EOF macro before we try to do anything andpop_macroright before the end ofantlr-runtime.h.