-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Builder and Jenkins job for IPAM tests and Skip irrelevant tests from Flexible IPAM tests #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KMAnju-2021
commented
Feb 12, 2025
•
edited
Loading
edited
- adding --skip mode-irrelevant flag for the Flexible IPAM tests in order to run fewer tests.
- Remove the Flexible-IPAM builder and job from jenkins as IPAM tests are now handled by GitHub workflows.
antoninbas
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll wait for @XinShuYang's review before merging
XinShuYang
reviewed
Feb 13, 2025
XinShuYang
reviewed
Feb 13, 2025
2da51e9
to
14ee316
Compare
XinShuYang
previously approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
antoninbas
previously approved these changes
Feb 19, 2025
/test-all |
@KMAnju-2021 sorry, I forgot to merge this PR, could you rebase? |
Signed-off-by: KMAnju-2021 <[email protected]>
a5ee780
14ee316
to
a5ee780
Compare
antoninbas
approved these changes
Feb 28, 2025
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.