Fix crash when deleting the Secret storing BGP passwords #7042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
added
action/backport
hongliangl
force-pushed
the
20250304-fix-crash-when-deleting-secret
branch
from
fa5a63b to
6597614
Compare
antoninbas
reviewed
Mar 4, 2025
| updatedIPv4Peer3Config.Password = "updated-" + peer3AuthPassword | ||
| mockBGPServer.EXPECT().UpdatePeer(gomock.Any(), updatedIPv4Peer1Config) | ||
| mockBGPServer.EXPECT().UpdatePeer(gomock.Any(), updatedIPv4Peer3Config) | ||
| copiedIPv4Peer1Config := ipv4Peer1Config |
There was a problem hiding this comment.
for the variable names, maybe something like expectedIPv4Peer1Config would make more sense, since you are using these variables to set expectations on mockBGPServer. I find the copied prefix a bit misleading in this context.
Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20250304-fix-crash-when-deleting-secret
branch
from
6597614 to
dc120bc
Compare
|
/test-all |
luolanzone
reviewed
Mar 4, 2025
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Mar 5, 2025
) Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Mar 5, 2025
) Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Mar 5, 2025
) Signed-off-by: Hongliang Liu <[email protected]>
tnqn
pushed a commit
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Hongliang Liu <[email protected]>
tnqn
pushed a commit
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Hongliang Liu <[email protected]>
tnqn
pushed a commit
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Hongliang Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.