update test (#1846)

* chore: fix test * chore: update vite version * chore: update test snapshots * chore: remove pnpm-lock.yaml * chore: update workflows --------- Co-authored-by: Aaron <[email protected]>
antvis · Nov 25, 2024 · 93c69fa · 93c69fa
1 parent a2b137e
commit 93c69fa
Show file tree

Hide file tree

Showing 13 changed files with 26 additions and 14,630 deletions.
diff --git a/.github/workflows/test.yml → .github/workflows/ci.yml b/.github/workflows/test.yml → .github/workflows/ci.yml
@@ -17,25 +17,27 @@ jobs:
         with:
           python-version: '3.10'
 
-      - uses: pnpm/action-setup@v2
-        with:
-          version: 9
-
-      - name: Use Node.js 20
+      - name: Use Node.js
         uses: actions/setup-node@v3
         with:
           node-version: 20
-          cache: 'pnpm'
+
+      - uses: pnpm/action-setup@v4
+        with:
+          version: 9
 
       - name: Install dependencies
-        run: pnpm install
+        run: pnpm install --no-frozen-lockfile
 
       - name: Install Playwright browsers
         run: npx playwright install --with-deps
 
       - name: Build
         run: pnpm build
 
+      - name: Lint
+        run: pnpm lint
+
       - name: Test
         run: pnpm test
 

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
diff --git a/.gitignore b/.gitignore
@@ -12,6 +12,7 @@ pids
 *.seed
 *.pid.lock
 yarn.lock
+pnpm-lock.yaml
 .dumi
 
 # Directory for instrumented libs generated by jscoverage/JSCover

diff --git a/__tests__/index.html b/__tests__/index.html
@@ -5,14 +5,17 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>G: Preview</title>
     <style>
-      /* html {
+      html {
         margin: 0;
         padding: 0;
+        box-sizing: border-box;
       }
       body {
+        width: 100vw;
+        height: 100vh;
         margin: 0;
         padding: 8px;
-      } */
+      }
 
       .lil-gui.root {
         position: absolute;

diff --git a/__tests__/integration/generator.ts b/__tests__/integration/generator.ts
@@ -45,7 +45,7 @@ export function generateCanvasTestCase(
 
         // Chart already rendered, capture into buffer.
         const buffer = await page
-          .locator(renderer === 'svg' ? 'svg' : 'canvas')
+          .locator(`#container ${renderer === 'svg' ? 'svg' : 'canvas'}`)
           .screenshot();
 
         const dir = `${__dirname}/snapshots/${namespace}/${renderer}`;

diff --git a/__tests__/integration/snapshots/2d/canvas/text.png b/__tests__/integration/snapshots/2d/canvas/text.png
diff --git a/__tests__/integration/snapshots/2d/svg/text.png b/__tests__/integration/snapshots/2d/svg/text.png
diff --git a/__tests__/integration/snapshots/2d/webgl/text.png b/__tests__/integration/snapshots/2d/webgl/text.png
diff --git a/__tests__/main.ts b/__tests__/main.ts
@@ -155,10 +155,11 @@ plot();
 async function plot() {
   if (currentContainer) {
     currentContainer.remove();
-    if (canvas) canvas.destroy(false, true);
+    if (canvas) canvas.destroy();
     if (prevAfter) prevAfter();
   }
   currentContainer = document.createElement('div');
+  currentContainer.id = 'container';
   app.append(currentContainer);
   const render = tests[selectChart.value];
   render?.(currentContainer);
@@ -233,7 +234,7 @@ function createSpecRender(object) {
       $stats.style.position = 'fixed';
       $stats.style.left = '2px';
       $stats.style.top = '2px';
-      // document.body.appendChild($stats);
+      document.body.appendChild($stats);
 
       // GUI
       const gui = new lil.GUI({ autoPlace: false });

diff --git a/__tests__/unit/abstract-renderer.spec.ts b/__tests__/unit/abstract-renderer.spec.ts
@@ -22,6 +22,7 @@ describe('Abstract renderer', () => {
       enableRenderingOptimization: false,
       enableDirtyRectangleRendering: true,
       enableDirtyRectangleRenderingDebug: false,
+      enableRenderingOptimization: false,
       enableSizeAttenuation: true,
     });
 

diff --git a/__tests__/unit/display-objects/display-object.node.spec.ts b/__tests__/unit/display-objects/display-object.node.spec.ts
@@ -209,11 +209,11 @@ describe('DisplayObject Node API', () => {
         return group.get('name') === 'group5';
       }),
     ).toBeNull();
-    // expect(
-    //   group1.find(() => {
-    //     return true;
-    //   }),
-    // ).toBe(group4);
+    expect(
+      group1.find(() => {
+        return true;
+      }),
+    ).toBe(group2);
 
     expect(
       group1.findAll(() => {

diff --git a/package.json b/package.json
@@ -115,7 +115,7 @@
     "tinybench": "^3.0.3",
     "ts-jest": "^29.1.1",
     "typescript": "^5.6.2",
-    "vite": "^3.2.7",
+    "vite": "^4.5.5",
     "webfontloader": "^1.6.28"
   },
   "limit-size": [