Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize performance #1789

Merged
merged 19 commits into from
Oct 22, 2024
Merged

perf: optimize performance #1789

merged 19 commits into from
Oct 22, 2024

Conversation

Aarebecca
Copy link
Contributor

@Aarebecca Aarebecca commented Oct 16, 2024 •
edited
Loading

标有 ⚠️ 的表示具有 break change，可能对现有依赖造成影响

  1. 移除 enableCSSParsing ⚠️
  2. 清理部分 CSS 解析模块
  3. 优化对象分配以减少 GC
  4. 提供 Fragment 以支持批量插入元素
  5. 优化内存多个内存泄漏点
  6. 移除 G 3.0 相关适配逻辑 ⚠️
  7. 优化部分语法性能
  8. Transform 支持数组格式传入

@Aarebecca Aarebecca force-pushed the perf/optimize-proposal branch from b4c820b to af9d607 Compare October 16, 2024 13:49
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2024
View reviewed changes
packages/g-lite/src/css/parser/transform.ts Dismissed Show dismissed Hide dismissed
@Aarebecca Aarebecca force-pushed the perf/optimize-proposal branch 2 times, most recently from 99a1b4a to 01ba274 Compare October 17, 2024 07:25
@Aarebecca Aarebecca force-pushed the perf/optimize-proposal branch from 01ba274 to 1dd60b5 Compare October 17, 2024 07:32
@Aarebecca Aarebecca force-pushed the perf/optimize-proposal branch from 259ce4e to 4cc14d0 Compare October 17, 2024 08:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2024
View reviewed changes
packages/g-lite/src/plugins/PrepareRendererPlugin.ts
Comment on lines +143 to +144
!isNaN(rBushNode.aabb.maxX) &&
!isNaN(rBushNode.aabb.maxX) &&

Check warning

Code scanning / CodeQL

Identical operands Warning

Operands
!isNaN( ... b.maxX)
Loading
and
!isNaN( ... b.maxX)
Loading
are identical.
@Aarebecca Aarebecca force-pushed the perf/optimize-proposal branch from 448fad0 to a32363c Compare October 18, 2024 12:27
@Aarebecca Aarebecca changed the title wip: perf optimize proposal perf: optimize performance Oct 22, 2024
@Aarebecca Aarebecca mentioned this pull request Oct 22, 2024
Closed
8 tasks
@Aarebecca Aarebecca changed the base branch from next to release October 22, 2024 03:47
@wang1212
Copy link
Member

  1. 移除 enableCSSParsing
  2. 清理部分 CSS 解析模块
  3. 优化对象分配以减少 GC
  4. 提供 Fragment 以支持批量插入元素
  5. 优化内存多个内存泄漏点
  6. 移除 G 3.0 相关适配逻辑
  7. 优化部分语法性能
  8. Transform 支持数组格式传入

建议标记一下 BREAKING CHANGE

@Aarebecca Aarebecca merged commit df950a9 into release Oct 22, 2024
3 checks passed
@Aarebecca Aarebecca deleted the perf/optimize-proposal branch October 22, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aarebecca @wang1212