Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lineDash支持多位数组 #1867

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

HuangLiangchen
Copy link

修复path/line style lineDash不支持多位数组

#1866

@HuangLiangchen HuangLiangchen marked this pull request as draft December 10, 2024 07:51
@Aarebecca
Copy link
Contributor

可以提供相关绘制效果截图吗

@HuangLiangchen
Copy link
Author

@HuangLiangchen HuangLiangchen marked this pull request as ready for review December 10, 2024 07:55
@hustcc hustcc requested a review from a team December 10, 2024 14:29
@wang1212 wang1212 changed the base branch from next to release December 11, 2024 01:57
@wang1212
Copy link
Member

wang1212 commented Dec 11, 2024

webgl 测试失败,dom 标准默认会将 lineDash 数组元素处理成偶数,webgl 需要手动处理,建议可以增加 size = 'even',而不是在解析 lineDash 时简单的将 size = 2 参数去掉

@hustcc
Copy link
Member

hustcc commented Dec 11, 2024

webgl 测试失败,dom 标准默认会将 lineDash 数组元素处理成偶数,webgl 需要手动处理,建议可以增加 size = 'even',而不是在解析 lineDash 时简单的将 size = 2 参数去掉

相当于这个特性是 webgl 不支持吗?

@wang1212
Copy link
Member

webgl 测试失败,dom 标准默认会将 lineDash 数组元素处理成偶数,webgl 需要手动处理,建议可以增加 size = 'even',而不是在解析 lineDash 时简单的将 size = 2 参数去掉

相当于这个特性是 webgl 不支持吗?

canvas 2d 支持一些参数的简写方式,webgl 基本都是上层来实现的,所以要同时兼容的话得上层把参数简写要解析成最终的形式

@wang1212 wang1212 merged commit e80c0fe into antvis:release Dec 12, 2024
3 checks passed
@HuangLiangchen HuangLiangchen deleted the fix/lineDash branch December 12, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants