Chore update engine line(finished) #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 切换fillImage到G引擎 * feat: 补充上体提交代码 * feat: radar和fillImage支持G引擎(有bug) * fix: 调整radar中uniform块中对象的顺序(遍历时一般按照unicode排序) * fix: 修改radar shader中的拼写错误 --------- Co-authored-by: huyang <[email protected]>
chore: 升级线图层到G-Device引擎 # Conflicts: # dev-demos/features/point/pointFillImage.md # packages/layers/src/core/CommonStyleAttribute.ts # packages/layers/src/point/models/fillImage.ts # packages/layers/src/point/models/radar.ts # packages/layers/src/point/shaders/image/fillImage_frag.glsl # packages/layers/src/point/shaders/image/fillImage_vert.glsl # packages/renderer/src/regl/ReglModel.ts
|
todo:greateCircle和flow有uniformBlock长度错乱的问题 |
|
arc_3d.ts功能貌似完全覆盖了earthArc_3d.ts,后者没有升级 |
|
原因是 Shader 中 UniformBlock 少了一个空格，导致解析时没匹配上正则（稍后我会在底层修改下兼容）： // before
layout(std140) uniform commonUniforms{
// after
layout(std140) uniform commonUniforms {另外在 Buffer 上新增了 label 便于 debug： this.commonUnifoms = this.rendererService.createBuffer({
data: new Float32Array(
MultipleOfFourNumber(commonUniforms.uniformsLength),
).fill(0),
isUBO: true,
label: 'commonUniforms', // 添加一个标签
});这样在使用 Spector.js 时可以查看 metadata：
|
Closed
10 tasks
|
更新到 |
added 4 commits
December 8, 2023 16:45
…into chore_updateEngine_line # Conflicts: # packages/layers/src/line/shaders/line_arc_great_circle_frag.glsl # packages/layers/src/line/shaders/line_arc_great_circle_vert.glsl
|
目前基本完成所有线的迁移 |
taiyuanhy
changed the title
taiyuanhy
changed the title
这个应该是渲染流程的问题，估计之前绘制的被清除了 |
* chore: 环境变量设置 renderer * chore: 设置 环境变量
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
☑️ 请求合并前的自查清单