-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove old amap v1 and v2 #2435
Conversation
代码量减少了 3.8% (1867 行,49231 -> 47364 ) |
发现 l7-three 使用 mapbox 为底图时,并没有支持 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大致看了一下代码,问题不大,重点还需要看一下已有demo 是否表现一致,新的模式可能影响法线方向的问题,会影响光照和高度,宽度相关的计算
重点关注:
- 3D 点图层,面图层高度和光照效果是否表现一致
- 线图层: wall lineheight 是否表现一致
- flow line 箭头问题
- 3D heatmap 是否抖动
另外考虑一下版本发布的,是否发布 3.0 做breakchange 升级, Map 升级之后是否把 L7-Maps 抽离出来, L7 内部不引用Map,
Maps 抽离出来,要发大版本,感觉还是得地图模块彻底重构后才合适,现阶段拆出去,就是一个包放到外面的拆分,彻底重构还有以下事情:
|
之前部分 shape 错误将光照放在投影计算之前,已订正。现光照效果与底图无关,且一致。 |
一致 |
3D 热力一直存在高层级抖动,其抖动原因是纹理计算过程中精度丢失 相关 issues |
🤔 这个变动的性质是?
相关 Issues
#2411
💡 需求背景和解决方案
旧版高德地图方案移除,高德 V2 地图接入升级为统一的视口同步
f66bb79
(#2435)后续 Actions