fix: memory leak of graph view dispose(introduce by #4023) (#4114)

Co-authored-by: cluezhang <[email protected]>
antvis · Jan 9, 2024 · 8d0a850 · 8d0a850
1 parent c91a89f
commit 8d0a850
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/packages/x6/src/graph/view.ts b/packages/x6/src/graph/view.ts
@@ -18,6 +18,11 @@ export class GraphView extends View {
 
   private restore: () => void
 
+  /** Graph's `this.container` is from outer, should not dispose */
+  protected get disposeContainer(): boolean {
+    return false
+  }
+
   protected get options() {
     return this.graph.options
   }

diff --git a/packages/x6/src/view/view.ts b/packages/x6/src/view/view.ts
@@ -13,6 +13,11 @@ export abstract class View<A extends EventArgs = any> extends Basecoat<A> {
     return 2
   }
 
+  /** If need remove `this.container` DOM */
+  protected get disposeContainer() {
+    return true
+  }
+
   constructor() {
     super()
     this.cid = Private.uniqueId()
@@ -39,8 +44,12 @@ export abstract class View<A extends EventArgs = any> extends Basecoat<A> {
       this.removeEventListeners(document)
       this.onRemove()
       delete View.views[this.cid]
+      if (this.disposeContainer) {
+        this.unmount(elem)
+      }
+    } else {
+      this.unmount(elem)
     }
-    this.unmount(elem)
     return this
   }
 
@@ -363,10 +372,10 @@ export abstract class View<A extends EventArgs = any> extends Basecoat<A> {
     return View.normalizeEvent(evt)
   }
 
-  // @View.dispose()
-  // dispose() {
-  //   this.remove()
-  // }
+  @View.dispose()
+  dispose() {
+    this.remove()
+  }
 }
 
 export namespace View {