Another enhancement to control end-of-line in created file

src/Antyrama.Tools.Scribe.Core/AppServiceConfigurationGenerator.cs

@@ -35,8 +35,8 @@ public void Generate()
             .ToDictionary(s => s.Key, s => s.Value);
 
         var repository = _options.WrapInYaml
-            ? (ConfigurationRepository)new YamlConfigurationRepository(_options.YamlVariableName)
-            : new JsonConfigurationRepository();
+            ? (ConfigurationRepository)new YamlConfigurationRepository(_options.YamlVariableName, _options)
+            : new JsonConfigurationRepository(_options);
 
         foreach (var filename in GetConfigurationFiles(_options))
         {
@@ -48,7 +48,7 @@ public void Generate()
         }
     }
 
-    private IReadOnlyDictionary<string, IReadOnlyDictionary<string, object>> Load(IConfigurationRepository repository, string filename)
+    private static IReadOnlyDictionary<string, IReadOnlyDictionary<string, object>> Load(IConfigurationRepository repository, string filename)
     {
         try
         {
@@ -62,7 +62,7 @@ private IReadOnlyDictionary<string, IReadOnlyDictionary<string, object>> Load(IC
         }
     }
 
-    private void Save(IConfigurationRepository repository, string filename, IEnumerable<IReadOnlyDictionary<string, object>> settings)
+    private static void Save(IConfigurationRepository repository, string filename, IEnumerable<IReadOnlyDictionary<string, object>> settings)
     {
         using var stream = new FileStream(filename, FileMode.Create, FileAccess.Write);
 
@@ -119,6 +119,5 @@ private IEnumerable<string> GetConfigurationFiles(ToolInternalOptions options)
         }
 
         throw new InvalidOperationException("File path template must contain '{0}' as environment placeholder when environments specified.");
-
     }
 }

src/Antyrama.Tools.Scribe.Core/Repository/ConfigurationRepository.cs

@@ -15,19 +15,26 @@ internal interface IConfigurationRepository
 
 internal abstract class ConfigurationRepository : IConfigurationRepository
 {
+    private readonly string _eol;
+
+    protected ConfigurationRepository(ToolInternalOptions options)
+    {
+        _eol = ResolveEndOfLine(options);
+    }
+
     public abstract IReadOnlyDictionary<string, object>[] Load(Stream stream);
 
     public abstract void Save(Stream stream, IEnumerable<IReadOnlyDictionary<string, object>> settings);
 
-    protected static string Serialize(IEnumerable<IReadOnlyDictionary<string, object>> settings)
+    protected string Serialize(IEnumerable<IReadOnlyDictionary<string, object>> settings)
     {
         var serialized = settings.Select(setting => $"  {JsonConvert.SerializeObject(setting)}");
 
-        var separator = $",{Environment.NewLine}";
+        var separator = $",{_eol}";
         var formatted = string.Join(separator, serialized)
             .BeautifyJson();
 
-        return $"[{Environment.NewLine}{formatted}{Environment.NewLine}]";
+        return $"[{_eol}{formatted}{_eol}]";
     }
 
     protected static IReadOnlyDictionary<string, object>[] Deserialize(string settings)
@@ -43,4 +50,20 @@ protected static IReadOnlyDictionary<string, object>[] Deserialize(string settin
             return Array.Empty<IReadOnlyDictionary<string, object>>();
         }
     }
+
+    private static string ResolveEndOfLine(ToolInternalOptions options)
+    {
+        return options.Eol switch
+        {
+            EndOfLine.Cr => Cr,
+            EndOfLine.CrLf => CrLf,
+            EndOfLine.Lf => Lf,
+            null => Environment.NewLine,
+            _ => throw new ArgumentOutOfRangeException(nameof(options))
+        };
+    }
+
+    private const string Cr = "\r";
+    private const string CrLf = "\r\n";
+    private const string Lf = "\n";
 }

src/Antyrama.Tools.Scribe.Core/Repository/JsonConfigurationRepository.cs

@@ -6,6 +6,10 @@ namespace Antyrama.Tools.Scribe.Core.Repository;
 
 internal class JsonConfigurationRepository : ConfigurationRepository
 {
+    public JsonConfigurationRepository(ToolInternalOptions options) : base(options)
+    {
+    }
+
     public override IReadOnlyDictionary<string, object>[] Load(Stream stream)
     {
         try

src/Antyrama.Tools.Scribe.Core/Repository/YamlConfigurationRepository.cs

@@ -12,7 +12,8 @@ internal class YamlConfigurationRepository : ConfigurationRepository
     private readonly Serializer _serializer;
     private readonly Deserializer _deserializer;
 
-    public YamlConfigurationRepository(string variableName)
+    public YamlConfigurationRepository(string variableName, ToolInternalOptions options)
+        : base(options)
     {
         _serializer = new SerializerBuilder()
             .WithAttributeOverride<Variables>(variables => variables.AppConfig,

src/Antyrama.Tools.Scribe.Core/ToolOptions.cs

@@ -38,6 +38,10 @@ public class ToolOptions
     [Option('e', "environments", Required = false, Default = new string[0],
         HelpText = "A list of environment names. Separate configuration file will be created per each environment. Required when file name template contains placeholder.")]
     public IEnumerable<string> EnvironmentsList { get; set; }
+
+    [Option('l', "eol", Required = false,
+        HelpText = "End-of-line delimiter, possible values: Cr, CrLf or Lf, by default operating system end-of-line will be used.")]
+    public EndOfLine? Eol { get; set; }
 }
 
 [Verb("_generate", Hidden = true)]
@@ -75,4 +79,15 @@ public class ToolInternalOptions
     [Option('e', "environments", Required = false, Default = new string[0],
         HelpText = "A list of environment names. Separate configuration file will be created per each environment. Required when file name template contains placeholder.")]
     public IEnumerable<string> Environments { get; set; }
+
+    [Option('l', "eol", Required = false,
+        HelpText = "End-of-line delimiter, possible values: Cr, CrLf or Lf, by default operating system end-of-line will be used.")]
+    public EndOfLine? Eol { get; set; }
+}
+
+public enum EndOfLine
+{
+    Cr,
+    CrLf,
+    Lf
 }

tests/UnitTests/Repository/JsonConfigurationRepositoryTests.cs

@@ -0,0 +1,37 @@
+using System.Text;
+using Antyrama.Tools.Scribe.Core;
+using Antyrama.Tools.Scribe.Core.Repository;
+using FluentAssertions;
+
+namespace UnitTests.Repository;
+
+public sealed class JsonConfigurationRepositoryTests
+{
+    [Theory]
+    [InlineData(EndOfLine.CrLf, "\r\n")]
+    [InlineData(EndOfLine.Cr, "\r")]
+    [InlineData(EndOfLine.Lf, "\n")]
+    public void ShouldWriteAndReadConfigFileWithAllPossibleEndOfLines(EndOfLine? eol, string eolChars)
+    {
+        // arrange
+        var options = new ToolInternalOptions { Eol = eol };
+        var sut = new JsonConfigurationRepository(options);
+
+        using var stream = new MemoryStream();
+
+        // act
+        sut.Save(stream,
+            new IReadOnlyDictionary<string, object>[]
+            {
+                new Dictionary<string, object> { { "key1", "value1" }, { "key2", "value2" } }
+            });
+
+        // assert
+        stream.Seek(0, SeekOrigin.Begin);
+
+        using var reader = new StreamReader(stream, Encoding.UTF8);
+        var result = reader.ReadToEnd();
+
+        result.Should().Contain(eolChars);
+    }
+}