Fix WebAssembly serialization for comments
field in CDDL AST
#231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues related to the serialization of the comments field in the CDDL Abstract Syntax Tree (AST) when targeting WebAssembly.
Problem
Previously, the comments field was marked with
#[cfg_attr(target_arch = "wasm32", serde(skip))]
which led to its omission during serialization in WebAssembly environments. While the intention was to avoid serializing the comments field conditionally, this caused discrepancies between WebAssembly and non-WebAssembly outputs, and made the behavior inconsistent when the ast-comments feature was enabled.
Solution
To fix this issue:
The
#[cfg_attr(target_arch = "wasm32", serde(skip))]
attribute has been removed from the comments field in the CDDL struct.
Both
Comments
andNonMemberKey
structs, which are part of the AST, were updated with#[cfg_attr(target_arch = "wasm32", derive(Serialize))]
This ensures they are properly serialized when compiling for WebAssembly.
By applying these changes, the comments field is now serialized correctly in WebAssembly environments when the ast-comments feature is enabled, aligning its behavior across all compilation targets.
Benefits