Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-5365: Rename joinSpace param to includeSpaceInfo in PublishingCreate #2264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Signed-off-by: AnastasiaShemyakinskaya <[email protected]>
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya marked this pull request as ready for review March 25, 2025 20:46
Copy link

Testomat.io Report 🟢 SMOKE-TEST PASSED
Tests ✔️ 8 tests run
Summary 🟢 8 passed; 🟡 0 skipped
Duration 🕐 13 minutes, 13 seconds
Testomat.io Report 📊 Run #5bd6ed22
Job 🗂️ Smoke Tests / smoke-test
Operating System 🖥️ Linux X64

✅ Passed Tests (8)

  • Revoking an invite link (3 minutes, 9 seconds)
  • User cancels their join request (1 minute, 23 seconds)
  • User deletes the space and rejoins later (1 minute, 39 seconds)
  • Owner changes the rights of a user from Viewer to Editor (1 minute, 48 seconds)
  • Owner approves a join request with Editor permissions (1 minute, 34 seconds)
  • Owner declines a join request (1 minute, 8 seconds)
  • Owner removes a participant from the space (1 minute, 23 seconds)
  • Sync on staging nodes (1 minute, 5 seconds)

Copy link

New Coverage 50.4% of statements
Patch Coverage 62.5% of changed statements (15/24)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

Copy link
Contributor

@requilence requilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming is confusing, need to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants