Rename/deprecate num_signatures to num_total_signatures #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
num_signatures
function name is confusing since it includes "actual" signatures on the transaction, as well as "pre-compile" signatures that are attached as instructions.Summary of Changes
SantizedMessage::num_signatures
SanitizedMessage::num_total_signatures
SVMMessage::num_signatures
toSVMMessage::num_total_signatures
to matchFixes #