shrink/ancient pack purge zero lamport accounts #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
4jul40
branch
18 times, most recently
from
c37b35e to
6c0f2aa
Compare
brooksprumo
reviewed
Aug 2, 2024
brooksprumo
reviewed
Aug 5, 2024
|
sorry @brooksprumo found a comment typo |
brooksprumo
approved these changes
Aug 5, 2024
HaoranYi
reviewed
Aug 6, 2024
HaoranYi
reviewed
Aug 6, 2024
There was a problem hiding this comment.
PR looks correct to me.
My understanding is that the current code in master is still correct but not
optimal.
In master, these single-ref zero lamports accounts will be copied into new
storage during shrink, but when next clean starts, it will drop these accounts
nevertheless.
With this PR, we are dropping these accounts earlier and don't wait for the
next round of clean.
Is that understanding correct?
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* shrink/ancient pack purge zero lamport accounts * pr feedback * add = * comment * fix comment typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when an account has 1 slot list entry and ref_count=1, it can be removed from the index (marked dead) and removed from storages. Currently, shrink and ancient pack operations carry along zero lamport accounts with a single refcount forever. This is not ideal.
Summary of Changes
Shrink and ancient pack do not copy over zero lamport accounts with slot_list=1 and ref_count=1. Since there are no other instances of the account, the account can be removed from the index and the storage. If it is reincarnated after loading a snapshot, clean will delete it again from the index.
Fixes #