Remove workaround compiler crash #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
remove-workaround
branch
from
ad5ef1d to
4a74ad7
Compare
LucasSte
force-pushed
the
remove-workaround
branch
from
4a74ad7 to
7e76774
Compare
Lichtso
approved these changes
Aug 2, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Remove workaround 16-byte aligned crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commit 5b39e3c introduced a change to bypass a compiler crash when copying 16-byte aligned memory. The latest platform tools release rendered the change unnecessary.
Summary of Changes
Reverted the changes.