forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract program-option crate #2369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
program-option-crate
branch
from
July 31, 2024 18:08
c7f89da
to
aed0f88
Compare
kevinheavey
force-pushed
the
program-option-crate
branch
from
September 5, 2024 12:30
aed0f88
to
dab0f69
Compare
joncinque
reviewed
Sep 6, 2024
joncinque
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks! @yihau can you accept the new solana-program-option
crate?
sure! crate check is green 🫡 |
kevinheavey
added
the
automerge
automerge Merge this Pull Request automatically once CI passes
label
Sep 6, 2024
joncinque
approved these changes
Sep 6, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract program-option crate * update lock file * update nits.sh * missing dev dep * mention Solana in description * remove solana_program from program_option doc examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::program_option
is used in a lot of places where it would be nice not to require all ofsolana_program
, most notably in solana-program-library crates.Summary of Changes