Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract program-option crate #2369

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

kevinheavey
Copy link

Problem

solana_program::program_option is used in a lot of places where it would be nice not to require all of solana_program, most notably in solana-program-library crates.

Summary of Changes

  • Move it to a new crate
  • Re-export in solana-program without deprecation

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! @yihau can you accept the new solana-program-option crate?

@yihau
Copy link
Member

yihau commented Sep 6, 2024

sure! crate check is green 🫡

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Sep 6, 2024
@mergify mergify bot merged commit aab5662 into anza-xyz:master Sep 6, 2024
54 checks passed
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
* extract program-option crate

* update lock file

* update nits.sh

* missing dev dep

* mention Solana in description

* remove solana_program from program_option doc examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants