Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

condition check outside of iterator #2372

Merged
merged 3 commits into from
Aug 1, 2024
Merged

condition check outside of iterator #2372

merged 3 commits into from
Aug 1, 2024

Conversation

kubanemil
Copy link

Problem

Unnecessary iteration in VerifiedVotePackets::receive_and_process_vote_packets()

Summary of Changes

moved if would_be_leader checker outside of for loop.

Fixes #2371

@mergify mergify bot requested a review from a team July 31, 2024 15:46
@kubanemil kubanemil requested a review from AshwinSekar July 31, 2024 16:19
@kubanemil kubanemil force-pushed the if_fix branch 2 times, most recently from 3a52d4a to 4f3215c Compare July 31, 2024 16:28
@kubanemil kubanemil requested a review from steviez August 1, 2024 00:08
@steviez steviez added the CI Pull Request is ready to enter CI label Aug 1, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Aug 1, 2024
steviez
steviez approved these changes Aug 1, 2024
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution! Started CI; will wait for that + a final look from Ashwin before pushing

@AshwinSekar AshwinSekar merged commit 376ed73 into anza-xyz:master Aug 1, 2024
42 checks passed
@kubanemil kubanemil deleted the if_fix branch August 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshwinSekar AshwinSekar AshwinSekar approved these changes

@steviez steviez steviez approved these changes

Assignees
No one assigned
Labels
community need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unneccessary gossip_votes iteration in VerifiedVotePackets::receive_and_process_vote_packets()
4 participants
@kubanemil @steviez @AshwinSekar @anza-team