Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/do-audit.sh: Remove stale exceptions #2426

Conversation

ilya-bobyr
Copy link

None of these show up in our audit reports anymore.

Also, clarify exceptions that are still present, to make it easier to connect them to the root cause and asses their validity in the future.

None of these show up in our audit reports any more.

Also, clarify exceptions that are still present, to make it easier to
connect them to the root cause and asses their validity in the future.
@ilya-bobyr ilya-bobyr requested review from yihau and willhickey August 3, 2024 06:39
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this one is read for review but LGTM! thank you!

@ilya-bobyr ilya-bobyr marked this pull request as ready for review August 5, 2024 18:27
@ilya-bobyr ilya-bobyr merged commit 7a9317f into anza-xyz:master Aug 5, 2024
19 checks passed
@ilya-bobyr ilya-bobyr deleted the pr/ci-do-audit-remove-stale-exceptions branch August 5, 2024 18:27
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
None of these show up in our audit reports anymore.

Also, clarify exceptions that are still present, to make it easier to
connect them to the root cause and asses their validity in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants