Break genesis loading and checks out of load_blockstore() #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, load_blockstore() does much more than just load the blockstore. Aside from the name being confusing, everything being in that single function caused some inefficiency, such as loading genesis a second time to have the config available earlier. So, break opening genesis and genesis related checks into a separate function. Also, add some variants to ValidatorError for the genesis specific errors to keep the error messages in one central place.
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
) Currently, load_blockstore() does much more than just load the blockstore. Aside from the name being confusing, everything being in that single function caused some inefficiency, such as loading genesis a second time to have the config available earlier. So, break opening genesis and genesis related checks into a separate function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, load_blockstore() does much more than just load the blockstore. Aside from the name being confusing, everything being in that single function caused some inefficiency, such as loading genesis a second time to have the config available earlier.
Summary of Changes
So, break opening genesis and genesis related checks into a separate function.