TransactionView: AddressTableLookupMeta #2479
Conversation
apfitzge
force-pushed
the
account_lookup_meta
branch
from
0f03a6c to
13c2c66
Compare
| const MAX_ATLS_PER_PACKET: usize = PACKET_DATA_SIZE / MIN_SIZED_ATL; | ||
| // Maximum number of ATLs should be represented by a single byte, | ||
| // thus the MSB should not be set. | ||
| const _: () = assert!(MAX_ATLS_PER_PACKET & 0b1000_0000 == 0); |
There was a problem hiding this comment.
I forgot about this for your other PRs, but Rust has const_assert_eq and const_assert (already available in our monorepo) that check constraints during compile time. Perhaps you can use them here (and in all the other cases - feel free to do that in another PR if you like my idea).
There was a problem hiding this comment.
Haven't looked at the crate that provides those, but have been trying to keep dependencies to minimum.
Doesn't seem necessary except for slightly nicer syntax, but I don't feel the syntax here is that bad honestly. Maybe you/others feel differently?
There was a problem hiding this comment.
The nicer syntax is my preference, but this is also a nitpick. I'll leave it up to you. Perhaps, just ask a second opinion from the other reviewers.
apfitzge
force-pushed
the
account_lookup_meta
branch
from
71a583c to
f34ea5f
Compare
apfitzge
force-pushed
the
account_lookup_meta
branch
from
e634d81 to
67d1a80
Compare
|
rebased sinced CI was skipping and i couldn't figure out how to get it to re-run jobs... |
Sometime I need to re-login to buildkite to make the |
Ah no, it was the github-side CI tasks. Usually there's a re-run button, but there wasn't 🤷♂️ |
Problem
Summary of Changes
MessageAddressTableLookupsFixes #