clippy: arithmetic-side-effects #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
requested review from
CriesofCarrots and
HaoranYi
and removed request for
CriesofCarrots
sdk/program/src/epoch_rewards.rs
Outdated
Comment on lines
45
to
47
| assert!(self.distributed_rewards.saturating_add(amount) <= self.total_rewards); | ||
|
|
||
| self.distributed_rewards.add_assign(amount); | ||
| self.distributed_rewards = self.distributed_rewards.saturating_add(amount); |
There was a problem hiding this comment.
The lint seems unnecessary here, but the change to saturating add is innocuous. I don't think we need to do the addition multiple times, though
How about this:
pub fn distribute(&mut self, amount: u64) {
let new_distributed_rewards = self.distributed_rewards.saturating_add(amount);
assert!(new_distributed_rewards <= self.total_rewards);
self.distributed_rewards = new_distributed_rewards;
}
There was a problem hiding this comment.
thank you for the insight! yeah, good catch! just fixed it! 34f81e7
CriesofCarrots
previously approved these changes
Aug 9, 2024
|
🤔 I'll look at that test failure. |
|
ah... sorry for missing the update for the test. just fixed it! |
CriesofCarrots
approved these changes
Aug 9, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* possible arithmetic_side_effects * feedback * fix test expected message * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(part of #2487)
Problem
Summary of Changes
replace
add_assignwithsaturating_add