refactor: load transaction result supports fee only transactions #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
refactor/load-transaction
branch
from
6182a23 to
194fc18
Compare
apfitzge
reviewed
Aug 12, 2024
svm/src/account_loader.rs
Outdated
Comment on lines
40
to
50
| pub enum TransactionLoadResult { | ||
| Loaded(LoadedTransaction), | ||
| FeesOnly(FeesOnlyTransaction), | ||
| NotLoaded(TransactionError), | ||
| } |
There was a problem hiding this comment.
Having brief descriptions of each variant would be great here imo.
Particularly good to mention that FeesOnly is still committed and also will affect nonce (not strictly fees only?).
edit: I guess rn they are not, so maybe we don't need to mention that 🤦♂️
There was a problem hiding this comment.
Let me know what you think of the description I added. I think you're right that documenting how nonces are handled for fees-only transactions is going to be really important to avoid confusion, probably during the PR that adds support for committing such transactions
There was a problem hiding this comment.
Nvm, I just added a bit more to the FeesOnly comment to talk about nonces as well.
apfitzge
previously approved these changes
Aug 12, 2024
apfitzge
previously approved these changes
Aug 13, 2024
jstarry
force-pushed
the
refactor/load-transaction
branch
from
c32af39 to
5031885
Compare
apfitzge
reviewed
Aug 13, 2024
apfitzge
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to support fee validated transactions that aren't executable, transaction account loading needs to be able to indicate the difference between fee validation errors and other account loading errors that happen post-fee validation
Summary of Changes
TransactionLoadResulttype alias with an enum that includes a variant forFeeOnlytransactions which have passed fee validation but cannot be executed due to an account loading errorFeesOnlyTransactionstruct which holds all relevant details for committing the aforementioned "fee-only" transactions to the ledger. Note that these details aren't used yet since this PR doesn't actually change any behavior to allow such transactions to be committed, this is just plumbing for now.. we still reject transactions unless they are executable.Fixes #